refactor: [M3-9647] - Reduce api requests made for every keystroke in Volume attach drawer #12052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Volume attach drawer
…647-reduce-api-calls-for-linode-volume
harsh-akamai
commented
Apr 17, 2025
| const { data: volume } = useVolumeQuery( | ||
| values.volume_id, | ||
| values.volume_id !== -1 | ||
| ); |
There was a problem hiding this comment.
Enabled the useVolumeQuery only when Volume_id is set and not -1(default value)
harsh-akamai
requested review from
dwiley-akamai and
hasyed-akamai
and removed request for
a team
bnussman-akamai
requested changes
Apr 17, 2025
packages/manager/src/features/Volumes/Drawers/VolumeDrawer/VolumeSelect.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Volumes/Drawers/VolumeDrawer/VolumeSelect.tsx
Show resolved
Hide resolved
github-project-automation
bot
moved this from Review
to Changes Requested
in Cloud Manager
…647-reduce-api-calls-for-linode-volume
bnussman-akamai
approved these changes
May 15, 2025
|
PR looks good now! Do we still need to add debouncing? |
…github.com/harsh-akamai/manager into M3-9647-reduce-api-calls-for-linode-volume
|
Added debouncing! cc: @bnussman-akamai |
Cloud Manager UI test results🔺 3 failing tests on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/placementGroups/placement-groups-linode-assignment.spec.ts,cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts,cypress/e2e/core/objectStorageMulticluster/bucket-create-multicluster.spec.ts" |
|||||||||||||||||||||||
hasyed-akamai
approved these changes
May 19, 2025
github-project-automation
bot
moved this from Changes Requested
to Approved
in Cloud Manager
hasyed-akamai
added
Approved
This was referenced May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
CM fires an API request for every keystroke in Volume attach drawer.
Changes 🔄
Target release date 🗓️
N/A
Preview 📷
Screen.Recording.2025-04-17.at.5.02.43.PM.mov
Screen.Recording.2025-04-17.at.5.07.32.PM.mov
How to test 🧪
Reproduction steps
/volumesrequest fired on each key storeVerification steps
/volumesrequest is only fired on the initial render of the drawerAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅